Merge queue: make dev checks required + add .asf.yaml validation#21239
Merged
Merge queue: make dev checks required + add .asf.yaml validation#21239
Conversation
github-actions
bot
added
the
development-process
Contributor
|
Amazing -- this will be so nice |
alamb
reviewed
Mar 30, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @blaginin
What do you think of the codeql suggestion to limit the token? I think that is a good idea in light of the recent npm supply chain attacks
Also, does this PR enable the merge queue? I didn't see any specific change but maybe I missed it
| contexts: | ||
| - "Check License Header" | ||
| - "Use prettier to check formatting of documents" | ||
| - "Validate required_status_checks in .asf.yaml" |
Member
Author
|
thanks for the review!
sure! i think we need to limit those for all the actions, will do that in a PR on top
it's actually already enabled! 
currently it's a no-op because there are no required checks (MQ only runs the required ones). once we add them, the merge queue will start working!
|
Contributor
|
So is the idea that once we merge this, we will be able to hit "merge' and the PR will merge once all the CI checks pass? |
Contributor
As in you will make a follow on PR to this one? |
alamb
approved these changes
Apr 2, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
We can finally have nice things!
This was referenced Apr 3, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 3, 2026
- Related to #21295 (comment) - Follow on to #21239 ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #. ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
zhuqi-lucas
pushed a commit
to zhuqi-lucas/arrow-datafusion
that referenced
this pull request
Apr 4, 2026
…che#21239) Related to apache#6880 Follow up on apache#17538 Bringing back the merge queues 🤞🏻 Last time it was painful because: - there was no `.asf.yaml` validation - if something goes wrong, we weren't able to force merge without the infra team this PR solved the first problem. As for the second one, I have the permissions to bypass so should be able to quickly revert if something ever goes bad <img width="830" height="151" alt="image" src="https://github.com/user-attachments/assets/62fb2bb5-44d8-4aae-a006-188d96728140" /> Check result: https://github.com/apache/datafusion/actions/runs/23715604583/job/69082077684?pr=21239 I also checked that CI will keep working by [merging](apache/datafusion-sandbox#197) this into our sandbox and then opening and merging [a dummy pr](apache/datafusion-sandbox#204) For now, bringing just the basic checks (in dev.yml). Will do rust.yml separately if everything goes smoothly after this one is merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #6880
Follow up on #17538
Bringing back the merge queues 🤞🏻
Last time it was painful because:
.asf.yamlvalidationthis PR solved the first problem. As for the second one, I have the permissions to bypass so should be able to quickly revert if something ever goes bad
Check result: https://github.com/apache/datafusion/actions/runs/23715604583/job/69082077684?pr=21239
I also checked that CI will keep working by merging this into our sandbox and then opening and merging a dummy pr
For now, bringing just the basic checks (in dev.yml). Will do rust.yml separately if everything goes smoothly after this one is merged